ep_ldapauth icon indicating copy to clipboard operation
ep_ldapauth copied to clipboard

Published 20 hours ago • verified publisher icon tykeal

Authorisation don't work

Open gjaekel opened this issue 3 years ago • 1 comments

I'm a newbie to etherpad. I try to get the LDAP integration running. Authenication is already working, but IMHO authentication seems to have an issue:

  • If is false in settings.json, the hook isn't called at all (as seen if loglevel is set to DEBUG).
  • If is set to true, any non-admin get forbidden at the web client.

Is it possible that the value returned at https://github.com/tykeal/ep_ldapauth/blob/42cd54c8f65ebb4b4c061b682be2acaf5486e0bc/ep_ldapauth.js#L174 should be true?

Because if I change it in this way, all _seems- to work so far. But I have no experience with Etherpad, yet and this change might be complete wrong.

gjaekel avatar Mar 15 '21 08:03 gjaekel

Maybe try with PR #47 applied. It removes the offending code that you have modified in PR 49.

pcworld avatar Dec 03 '21 00:12 pcworld