Terry Yiu

Results 63 comments of Terry Yiu

There's a bug when `damus_state.settings.auto_translate` is set to true but `Offline Translations` is selected. It won't show the Translate button in that case, which is incorrect. I'll work on a...

I mischaracterized the this PR. It's not exclusively offline note translations from Apple. The translation requests can still go to Apple servers, but can be offline as well via downloaded...

I rebased this branch on the latest master and force pushed. No other changes were made.

I'm not against it, I'm just saying I see a use case and am OK with how things are. With that said, I wouldn't mind the Bluesky approach where they...

Hmm, there's a bug rendering invoice strings in the selectable view.

OK, fixed it in my second commit. https://damus.io/nevent1qqs8f47tv4mdjkj78a96vg4sh8d2q0nvpwkzggjw7gz4flmhfk6vy4spzpmhxue69uhkummnw3ezuamfdejsz9thwden5te0v4jx2m3wdehhxarj9ekxzmnyqyxhwumn8ghj7mn0wvhxcmmvqy28wumn8ghj7un9d3shjtnyv9kh2uewd9hs8rusn4 https://github.com/user-attachments/assets/411816cf-5892-481d-adf7-b4f1b77b8f99

Oh, there's another issue that I didn't account for. If there are multiple consecutive previewable blocks at the end of the note content, their text should probably be hidden. I'll...

> Oh, there's another issue that I didn't account for. If there are multiple consecutive previewable blocks at the end of the note content, their text should probably be hidden....

I'm going to rebase on master and also amend 82fcf123d485cf016ab64a1bea8299b022d44711 into 9883a92ae943ae6948da50ef2c23bc9ab785ea9e for a cleaner branch history.

> we really should have some tests for these Agreed. I can do it as part of this PR if you feel that we need it before merging. It's always...