Liam DeVoe
Liam DeVoe
This is a result of [the v7.0.0 release](https://github.com/kszlim/osu-replay-parser/releases/tag/v7.0.0). I hadn't considered that users would expect written replays to preserve the initial break frames. I think @kszlim was right in suggesting...
This is available in v4.0.0 proper, which I've just released.
can you share a beatmap id that reproduces this?
Circleguard has an implementation of this at https://github.com/circleguard/circlecore/blob/57465bb7d16cce9846de06fcb248a718b3bff7c4/circleguard/enums.py#L17-L251 (https://github.com/circleguard/circlecore/pull/99), which seems a lot cleaner than passing every single mod.
am I misunderstanding or isn't the heavy lifting of this already done by [`Replay#hits`](https://github.com/llllllllll/slider/blob/833476b35aa4d9b2d67a5ae8fb5ee6dd651efa05/slider/replay.py#L691) (which already does sliderbreaks)? Once you have the judgments, you can reconstruct the combo and score...
Honestly speaking I'm not sure I'll have the bandwidth to look into this in the near future. PRs are always welcome though!
not sure why I never reviewed this PR properly but I'll try and get this in once my exams are over (only 2 years late...)
I pushed some significant structure changes to try and get this into a better state. I also removed the unimplemented events (sprite/animation) instead of half-implementing them; was more trouble than...
no worries, I kinda figured that was the case
for anyone following along - I'm not happy with how this PR deals with not-yet-implemented events, so I need to work on that before pushing this along. I have some...