Tal Yarkoni

Results 133 comments of Tal Yarkoni

Here, I dumped just the transformations into a separate document: https://docs.google.com/document/d/1uxN6vPWbC7ciAx2XWtT5Y-lBrdckZKpPdNUNpwRxHoU/edit?usp=sharing

Note that not all of the transformations in that document are currently implemented in PyBIDS—feel free to remove them from the doc (or, alternatively, to implement them in PyBIDS).

+1 for this, it would be a great addition. Feel free to raise issues/questions for discussion as they come up.

LGTM! It seems reasonable to wrap the plotting code in a standalone function that accepts a `DataFrame` and other arguments as input. Then you could maybe add a `plot()` method...

Good point, we could definitely wrap seaborn for this. Though, at least for the existing visualization, I think the plotting built into pandas itself would also work, and would save...

I think the sense from @qmac is that this is a bug in ffmpeg or moviepy (or reflects the interaction between the two). Will leave it open in case other...

@adelavega do you know if this is still a problem?

Okay, will continue to leave this open. Thanks for checking!

Thanks! One concern though is that without a matching `open()` method, this seems incomplete. If you `close()` a clip this way, without destroying the whole `stim`, then a user can...

Oh, and we should probably also do the same thing for `VideoStim` objects. Happy to add it myself if you don't have time.