Tal Yarkoni
Tal Yarkoni
I'm not sure, but note that the naming scheme here violates the spec: > If several scans of the same modality are acquired they MUST be indexed with a key-value...
If the validator didn't catch this, maybe we should open an issue there...
Oh, woops. Fine, fine, make my life more difficult... Actually, it doesn't have to be more difficult. Maybe I'll just... "delegate" :p
`sourcedata/` is included in the `_default_ignore` class variable, so in principle it shouldn't be indexed. The problem is that `_default_ignore` is only used if the user doesn't pass `ignore` explicitly,...
Actually, I don't think it's a huge deal for the user to manually add `["code", "stimuli", "sourcedata", "models"]` to `ignore`... is there a reason that won't work here? The `ignore`...
Ah, then it looks like a bug. Not clear to me what's happening, as `ignore` is passed directly through to `add_derivatives`. I initially thought maybe the paths were being expanded...
Thanks for flagging this; looks like PyBIDS needs to be updated to reflect changes to the spec. Unfortunately this won't be completely trivial, as the ability to have multiple values...
Following up on our conversation yesterday, I think a reasonable implementation approach is something like the following: * Add a `SparselyAcquiredDenseRunVariable` to the `Variable` hierarchy. This inherits from `DenseRunVariable` but...
@satra—I think the current implementation handles everything you mention, except for the transformation from `X` space to `Y` space in the case of sparse acquisition (which is what #376 will...
> i agree. the only other time this may become relevant is as a hint to the variables, actually more to the transforms, such that they can take the acquisition...