Tal Yarkoni

Results 133 comments of Tal Yarkoni

@effigies given that this will need to be updated to reflect #411, I wonder if this is also a good time to move the `sr` computation logic into `to_dense()` in...

The general idea was that computing the `sr` to take `TA` into account is going to be necessary *any* time densification occurs, not just in `Convolve`. So I think the...

Yet another good reason to prioritize #320 (not that I needed more)! Will try to get to that shortly.

Ah, heh, I see what's going on. When you request `layout.entities['subject']` with multiple layouts in scope (i.e., base and derivatives), the results are accumulated in a single dict. So, depending...

I think that second one qualifies as a PyBIDS bug though... metadata inside sidecars isn't controlled, so it should still be ingested and handled properly. I'm guessing the issue here...

@BarRozenman thanks for the report. The problem is coming from [this line](https://github.com/bids-standard/pybids/blob/71b3d0f6fa2514a16e5413993e997e49293a8221/bids/layout/layout.py#L699): the concatenation of various strings (the project root, entity pattern, etc.) ends up creating an unholy mishmash of...

If it works in 0.8, can we close this? The internals are almost completely reworked in 0.8, so there's no point in patching this for 0.7.1—I don't want to actively...

I'm going to merge master into 0.8, but there will probably be some recent PRs that no longer make sense given the refactoring in 0.8.

Oh, sorry, I didn't read the original report carefully. This is somewhere between bug and feature. What was previously happening is that we were restricting the entities tracked inside variables...

I should also note that making it so that `participants.tsv` doesn't have a suffix is arguably inconsistent with the way we treat all other files... i.e., it seems reasonable to...