Regression: Brook has no version number on macOS

[core-code]

download the latest version of 'Brook', and select it in the Finder and you'll see that the 'Version Number' is missing.

Both the CFBundleVersion and the CFBundleShortVersionString entries are missing from the Info.plist file of the current release.

previous versions up to and including version 20180909 did not have this problem

[core-code]

[core-code]

both the CFBundleVersion and the CFBundleShortVersion entries are missing in the Info.plist of the latest download

<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
	<dict>
		<key>CFBundleName</key>
		<string>Brook</string>
		<key>CFBundleExecutable</key>
		<string>brook</string>
		<key>CFBundleIconFile</key>
		<string>icon.icns</string>
		<key>CFBundleIdentifier</key>
		<string>com.txthinking.brook</string>
        <key>NSHighResolutionCapable</key>
        <true/>
        <key>LSUIElement</key>
        <false/>
	</dict>
</plist>

[txthinking]

v20200101

[core-code]

please re-open.

20210214 again contains neither a CFBundleVersion nor a CFBundleShortVersionString

[core-code]

same for 20210701

[txthinking]

I ignored CFBundleVersion and why you need to know the version on Info.plist.

[core-code]

I ignored CFBundleVersion

thats a bug. if you read Apple's documentation you'll see that each app needs it.

you need to know the version on Info.plist.

as you can see in the screenshot, the version numbers of you app don't show up in the Finder. Mac users expect to be able to see all version numbers in the Finder. also, 3rd party updaters won't work without then. also, the system will get confused if the app is installed multiple times.

[txthinking]

Thank you. I see.

On Thu, Jul 1, 2021 at 5:06 PM CoreCode @.***> wrote:

I ignored CFBundleVersion

thats a bug. if you read Apple's documentation you'll see that each app needs it.

you need to know the version on Info.plist.

as you can see in the screenshot, the version numbers of you app don't show up in the Finder. Mac users expect to be able to see all version numbers in the Finder. also, 3rd party updaters won't work without then. also, the system will get confused if the app is installed multiple times.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/txthinking/brook/issues/570#issuecomment-872067958, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJPFT5PURNJDDAMW47QFS3TVQVZ3ANCNFSM4HYIXHDA .

[txthinking]

v20230101

[core-code]

yes it is fixed now. thanks!