cdvae Underscore vs. hyphen in cli arg `mp

Underscore vs. hyphen in cli arg `mp_20` correct, `mp-20` not

Open sgbaird opened this issue 2 years ago • 1 comments

Not a big deal, but could add mp-20, perov-20, and carbon-20 in addition to the underscored versions for data=...

Jun 11 '22 22:06 sgbaird

Similarly, it has a third set of definitions, appearing as mp20, carbon, and perovskite in dict keys for the evaluation metrics.

https://github.com/txie-93/cdvae/blob/f857f598d6f6cca5dc1ea0582d228f12dcc2c2ea/scripts/compute_metrics.py#L26-L30

Jun 23 '22 21:06 sgbaird