Tom Wieczorek

Results 321 comments of Tom Wieczorek

Closing this as this still needs some feedback: https://github.com/k0sproject/k0s/issues/1775#issuecomment-1209571632. Please reach out in issue #1775 whenever you have time to provide more information. Will reopen it then.

Also seeing this issue. Probably introduced by https://github.com/jenkinsci/junit-plugin/pull/292/files#diff-c921adc7a4606b0ec68dae39f857ea5cda930888809b7e9dfd0e90ac2395ade6R150. Question is what is `null` there, `listener` or `listener.getLogger()`.

Docs build broke by the recent pip 22.3 release. Needs to wait for #2278.

And now waiting for the backport: #2286.

I think we can go without the `Ready` (the former `Healthy`) method at all, by just inlining the current calls to it into the `Start` methods of the components that...

Concerning `HealthCheckStatus`: * How are `Error` and `Message` supposed to be related. Is it mutually exclusive, i.e. either have an error or a message? Could be that we're going without...

> I'd rather have separate Ready and Healthy methods, because the logic might be different in those, [...] Absolutely. What I tried to say was that the component manager wouldn't...

I'm fine with enabling this. Concerning the migration path from enabling to disabling it: I think that it's not that of a big deal, as, IIUK, the annotations can also...

Having a tri-state setting sounds good. We still need to support the old settings as a fallback for backwards compatibility, though.