docker-registry.helm icon indicating copy to clipboard operation
docker-registry.helm copied to clipboard
verified publisher icon twuni

Use labels suggested by K8s and Helm best practices

Open pinkavaj opened this issue 6 months ago • 2 comments

This improves the compatibility and makes it easier to work with various tools, which take advantage from the assumption of existence of those labels.

https://helm.sh/docs/chart_best_practices/labels/
https://kubernetes.io/docs/concepts/overview/working-with-objects/common-labels/

Changing the selectors is breaking change, so the bump of the major version of the helm chart.

pinkavaj avatar Jun 14 '25 21:06 pinkavaj

I like what this does but do have to ask. Why does it need to be a breaking change? can the labels not co-exist for a time and a deprecation notice be given?

Mercbot7 avatar Jul 09 '25 13:07 Mercbot7

I like what this does but do have to ask. Why does it need to be a breaking change? can the labels not co-exist for a time and a deprecation notice be given?

Sure they can, NP here. updated

pinkavaj avatar Jul 09 '25 16:07 pinkavaj