pyaarlo icon indicating copy to clipboard operation
pyaarlo copied to clipboard

pyaarlo -u u -p p camera last-thumbnail: raise AttributeError

Open cpina opened this issue 1 year ago • 2 comments

No Arlo camera in the network or configured (so a strange case). Typing the command and doing nothing else seems raise the exception below.

carles@pinux:~$ pyaarlo -u u -p p camera last-thumbnail
2023-12-12 20:52:04,091:pyaarlo:ERROR: authentication failed
2023-12-12 20:52:08,023:pyaarlo:ERROR: authentication failed
Traceback (most recent call last):
  File "/home/carles/.local/bin/pyaarlo", line 33, in <module>
    sys.exit(load_entry_point('pyaarlo', 'console_scripts', 'pyaarlo')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/pyaarlo/main.py", line 408, in main_func
    cli()
  File "/usr/lib/python3/dist-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/pyaarlo/main.py", line 373, in camera
    for c in ar.cameras:
             ^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/pyaarlo/__init__.py", line 531, in cameras
    return self._cameras
           ^^^^^^^^^^^^^
AttributeError: 'PyArlo' object has no attribute '_cameras'. Did you mean: 'cameras'?

cpina avatar Dec 12 '23 20:12 cpina

Similar with at least list:

carles@pinux:~$ pyaarlo -u u -p p list all
2023-12-12 20:56:41,193:pyaarlo:ERROR: authentication failed
2023-12-12 20:56:45,009:pyaarlo:ERROR: authentication failed
Traceback (most recent call last):
  File "/home/carles/.local/bin/pyaarlo", line 33, in <module>
    sys.exit(load_entry_point('pyaarlo', 'console_scripts', 'pyaarlo')())
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/pyaarlo/main.py", line 408, in main_func
    cli()
  File "/usr/lib/python3/dist-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
         ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/pyaarlo/main.py", line 320, in list
    list_items("bases", ar.base_stations)
                        ^^^^^^^^^^^^^^^^
  File "/usr/lib/python3/dist-packages/pyaarlo/__init__.py", line 558, in base_stations
    return self._bases
           ^^^^^^^^^^^
AttributeError: 'PyArlo' object has no attribute '_bases'
carles@pinux:~$ 

Will not add others if they happen :-)

cpina avatar Dec 12 '23 20:12 cpina

I noticed that after your pull request. The code for login in needs updating to include 2 factor support.

I'll take a run at it this weekend.

twrecked avatar Dec 12 '23 21:12 twrecked