Tom Payne

Results 193 comments of Tom Payne

I would be concerned about the performance overhead of using mapstructure for every conversion, but there's no reason that such code couldn't be included as a separate encoding package and...

I need this again. As an alternative to the `?` operator (which, I agree, is the correct way to do it), how about adding a new verb `execdontcareaboutsuccess` verb, which,...

> Hi @twpayne, could you implement this yourself as small [custom command](https://pkg.go.dev/github.com/rogpeppe/go-internal/testscript#RunMain) that is specific to your project? I don't think so because the [existing implementation of `exec`](https://github.com/rogpeppe/go-internal/blob/ec119421bb970ac974ea4ac16d8b58ffd0d727fc/testscript/cmd.go#L226-L270) uses unexported...

Awesome, thank you very much :)

Hopefully this is now resolved. Please re-open if needed.

Making `ID` an `interface{}` would break backwards compatibility. I'm not personally affected by this bug, but would accept a high quality PR that fixes the issue without breaking backwards compatibility...

Note also that since numbers in JSON are all `float64`s, ids can also be`float64`s.

You need to create the pull request from your own fork. See [how to create a pull request](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request) in the GitHub documentation.

Fixed by @DmitriyVTitov in #225.

Please re-open this if you have a contribution.