Tom Payne
Tom Payne
Thank you everyone for contributing here. I'm locking this issue for a few days to give everybody (including me) a bit of time to cool down.
> [@twpayne](https://github.com/twpayne) how tested is your package against `pinentry-curses`? go-pinentry should be neutral with respect to the pinentry program used - it speaks the Assuan protocol which is text exchanged...
Sorry for being slow in reviewing this. This is a clear improvement and I do care. I will review this thoroughly soon.
Thinking more about this, I also want the [commit messages](https://github.com/twpayne/chezmoi/commits/master/) to be consistent with the main part of the message starting with a capital letter. Contributors not bothering to read...
Yup, you're right. The current commit message check does not match either the conventional commits specification or chezmoi's contributing guide. Thank you for raising this because you're totally right that...
Thanks for the speedy review! I'll have time to work on this again in a few days and will address all your comments.
> Only `.bashrc` changes should be committed to chezmoi's Git repo. Unrelated files in the current directory should **not** be included. This is not correct. As [documented](https://www.chezmoi.io/user-guide/daily-operations/#automatically-commit-and-push-changes-to-your-repo), chezmoi's auto commit...
Thanks for reporting this. I agree that `git.autoAdd` should only add files in the source directory, not in the entire working tree. Fixed in #4549.
I think this is now resolved. Please re-open if needed.
Thanks for reporting this! My understanding of Windows is that environment variables (like `$PATH`/`%PATH%`) on Windows behave very differently to UNIX-like systems. Specifically, whereas on UNIX-like systems environment variables are...