Subsonic icon indicating copy to clipboard operation
Subsonic copied to clipboard

Idea: Trigger an action when sound/audio finished playing

Open coderExMachina opened this issue 1 year ago • 4 comments

Hey, Subsonic is amazing! It would be great if there was a version of play() with a trailing closure that could contain an action to be triggered whenever the sound/audio finished playing. Cheers :)

coderExMachina avatar Sep 07 '23 20:09 coderExMachina

This sounds great! This is an open-source project, so I'd love to see you tackle this and submit a pull request.

twostraws avatar Sep 14 '23 18:09 twostraws

I submitted a pull request with a proposal how to achieve the described functionality. I would appreciate it if you could have a look. Let me know if there is anything ti be changed - this is my first pull request for an open source project, ever :D

coderExMachina avatar Jan 16 '24 22:01 coderExMachina

Thank you! It's much appreciated 🙌 I've asked for a little extra clarity about the code just to make sure it's all polished up, but hopefully this can get merged in soon.

twostraws avatar Jan 17 '24 22:01 twostraws

Hi! I made some changes to my pull request and hope that those address you concerns. Did you already have a chance to check those? Cheers!

coderExMachina avatar Feb 04 '24 20:02 coderExMachina