armory
armory copied to clipboard
[Feature]: Config output_dir does not behave as expected
- When supplying a value such as
INTL
asoutput_dir
, armory outputs the results to~/.armory/outputs/INTL_<generated_name>/…
as opposed to what would be expected~/.armory/outputs/INTL/<generated_name>/…
- When supplying an absolute path to
output_dir
it throws aPermission denied
error, if armory should still throw an error here, it might be useful to update the error message to inform the user thatoutput_dir
should be a relative path.
NOTE: Can supply INTL/
as the output_dir to have it output in that folder as a no-code-change fix
There is a lot of directory management/creation logic happening in armory/scenarios/scenario.py
and also armory/paths.py
.
I like the idea of consolidating all of the directory creation logic inside paths.py
but am curious about what others think.
Related to #1329. I agree if the output dir and filename values are supplied, Armory should not append the timestamps and IDs. @christopherwoodall Feel free to consolidate the logic in a way that makes sense to you if you are still interested in taking care of this