armory icon indicating copy to clipboard operation
armory copied to clipboard

remove references to getenv("ARMORY_VERSION") throughout

Open mwartell opened this issue 2 years ago • 4 comments

There are places e.g. environment.py which look to the environment for a version string. They should be re-pointed to use the 0.16 version primitives.

mwartell avatar Sep 29 '22 17:09 mwartell

I think the only reason this was done was to log a warning if the armory launcher has a different version than armory running the scenario: https://github.com/twosixlabs/armory/blob/master/armory/scenarios/main.py#L211-L216

davidslater avatar Sep 30 '22 19:09 davidslater

Just to start discussion around the issue, is armory_launcher a different application from armory_scenarios or just a way to interact with the scenario runner "API"? If the later is true(the launcher is an API client) is the version of the client or the API what really matters? Example, systemd, the manager, and systemctl, the cli used to communicate.

christopherwoodall avatar Sep 30 '22 20:09 christopherwoodall

There isn't a clean distinction or API at the moment. Probably will become less of an issue once we do a better job of separating the two.

davidslater avatar Sep 30 '22 21:09 davidslater

Rename to CLIENT_ARMORY_VERSION? Used to log a warning if the version used in the container differs from the version used in the client (since we don't have an API versioning mechanism)

davidslater avatar Dec 05 '22 19:12 davidslater