git-meta icon indicating copy to clipboard operation
git-meta copied to clipboard

libgit2 `rebase` tries to use commit message to construct the names of files during conflict resolution

Open bpeabody opened this issue 7 years ago • 2 comments

When the commit message is too long, this yields errors such as:

Error: could not open '/foo/bar.cpp~$very-long-commit-message: File name too long
    at Error (native)

bpeabody avatar Feb 05 '18 20:02 bpeabody

I have a patch for this, but it's actually a little irritating to test because you there's no such thing as unit tests -- you can only write integration tests. It's a shame, because this function would be trivial to unit-test, and is quite difficult to integration test thoroughly. Will do more on this tomorrow.

novalis avatar Feb 06 '18 00:02 novalis

https://github.com/libgit2/libgit2/pull/4520

novalis avatar Feb 08 '18 02:02 novalis