beakerx icon indicating copy to clipboard operation
beakerx copied to clipboard

Switching kernels in a notebook with tabledisplay causes a runtime error.

Open afshin opened this issue 5 years ago • 0 comments

If a notebook has a BeakerX tabledisplay in it and the user switches kernels, the keydown handler for tabledisplay functionality causes a failure here: https://github.com/twosigma/beakerx/blob/bef44325c1b98c813a4efd244e15e7ec2f84fe03/js/lab/src/plugin/index.ts#L83

As a general principle, if we can remove the need for window.beakerx in favor of a private module variable, it would be better practice, but that is orthogonal to this specific bug.

Thank you!

afshin avatar Jun 03 '20 13:06 afshin