beakerx icon indicating copy to clipboard operation
beakerx copied to clipboard

Future Warning in Table Display

Open JohnOmernik opened this issue 6 years ago • 10 comments
trafficstars

Getting this when tables are displayed. Only started happening recently.

/opt/conda/lib/python3.7/site-packages/beakerx/tabledisplay/tabledisplay.py:109: FutureWarning: The 'get_values' method is deprecated and will be removed in a future version. Use '.to_numpy()' or '.array' instead. value = args[0][columnName].get_values()[index]

JohnOmernik avatar Jul 24 '19 15:07 JohnOmernik

Hi @JohnOmernik I'm not able to reproduce this warning. Could you provide more details?

jaroslawmalekcodete avatar Aug 07 '19 13:08 jaroslawmalekcodete

So I just did a bunch of upgrading. Running BeakerX 1.4.0, and recent versions of Pandas and Jupyter Lab and still getting:

/opt/conda/lib/python3.7/site-packages/beakerx/tabledisplay/tabledisplay.py:109: FutureWarning: The 'get_values' method is deprecated and will be removed in a future version. Use '.to_numpy()' or '.array' instead. value = args[0][columnName].get_values()[index] /opt/conda/lib/python3.7/site-packages/beakerx/tabledisplay/tabledisplay.py:114: FutureWarning: The 'get_values' method is deprecated and will be removed in a future version. Use '.to_numpy()' or '.array' instead. index_values = args[0].index.get_values()[index]

JohnOmernik avatar Aug 12 '19 17:08 JohnOmernik

@jaroslawmalekcodete I saw these warnings and fixed them while extracting table display so it's fixed in the current master, but i don't think it's released yet

piorek avatar Aug 20 '19 13:08 piorek

What is the timeline for 1.4.1 to be released (into the Conda repos?)

On Tue, Aug 20, 2019 at 8:28 AM Łukasz Pior [email protected] wrote:

@jaroslawmalekcodete https://github.com/jaroslawmalekcodete I saw these warnings and fixed them while extracting table display so it's fixed in the current master, but i don't think it's released yet

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/twosigma/beakerx/issues/8097?email_source=notifications&email_token=AAOXGUPFK3LNU5BCWUIYRVTQFPWPBA5CNFSM4IGRFAHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4WJDYQ#issuecomment-523014626, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOXGULM32ETVHM7DAKGARLQFPWPBANCNFSM4IGRFAHA .

JohnOmernik avatar Aug 20 '19 13:08 JohnOmernik

With Beakerx version 1.4.1, I am getting the same warning:

/opt/conda/lib/python3.7/site-packages/beakerx/tabledisplay/tabledisplay.py:109: FutureWarning: The 'get_values' method is deprecated and will be removed in a future version. Use '.to_numpy()' or '.array' instead.
  value = args[0][columnName].get_values()[index]

mahsheed avatar Jan 30 '20 20:01 mahsheed

Yes, and when Pandas got updated to 1.0.0 the get_values is gone, and is now erroring out instead of just providing warnings.

JohnOmernik avatar Jan 30 '20 20:01 JohnOmernik

Originally, I got this warning and error mentioned above from following the JupyterLab installation instructions provided from the BeakerX website, but installing in the following way instead seems to prevent the error. However, I still get the warning "tabledisplay.py:109: FutureWarning: The 'get_values' method is deprecated and will be removed in a future version. Use '.to_numpy()' or '.array' instead."

pip install beakerx==1.4.1
jupyter labextension install @jupyter-widgets/jupyterlab-manager
jupyter labextension install beakerx-jupyterlab
pip install py4j
beakerx install

mahsheed avatar Feb 12 '20 19:02 mahsheed

Is there a timeline to release a fix to conda repo? Now it errors out instead of giving warnings with pandas at 1.0.0:

AttributeError: 'Series' object has no attribute 'get_values'

I have following packages: - beakerx=1.4.1=py37_1 - pandas=1.0.0=py37h0573a6f_0 - numpy=1.18.1=py37h4f9e942_0 - jupyterlab=1.2.6=py_0

SichongP avatar Mar 09 '20 22:03 SichongP

This has to do with an issue between beakerx and Pandas 1.0, hence why we were getting future warnings on the version of Pandas just prior to 1.0, it was warning us something was going away, now that Pandas is 1.0, this is not working.

On Mon, Mar 9, 2020 at 5:24 PM Sichong [email protected] wrote:

Is there a timeline to fix this issue? Now it errors out instead of giving warnings with pandas at 1.0.0:

AttributeError: 'Series' object has no attribute 'get_values'

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/twosigma/beakerx/issues/8097?email_source=notifications&email_token=AAOXGULJJLCORXFBMGF2B43RGV3CJA5CNFSM4IGRFAHKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOJJERI#issuecomment-596808261, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAOXGUJPVRAIPYO3CUCGMSTRGV3CJANCNFSM4IGRFAHA .

JohnOmernik avatar Mar 10 '20 12:03 JohnOmernik

Yes I got that the issue was caused by a deprecated function call in beakerx. I was wondering when it will be updated to be compatible with latest pandas?

Right now I can make it work by downgrading pandas but at some point people will surely need later versions of pandas.

This seems to have been fixed in the master branch but not in conda repo?

SichongP avatar Mar 10 '20 13:03 SichongP