twosatsmaxi
twosatsmaxi
@gmart7t2 @raphjaph : how do I forcefully spend the commitment here to write a failing test? can do it using `bitcoin-cli` but not sure, can use `ord wallet send` but...
@raphjaph @casey this ^ is ready for review now, no functionality changes, just refactoring.
> I personally don't think this is a huge increase in readability. But do you think though that it's a bit more readable?
> since there's just more indirection in figuring out what's going on. It simplify things a bit for new folks who want to read about what's going on in send.rs....
I feel that even if it adds a bit more readability and simplicity, there is no harm in checking in to main branch since all unit tests are passing, unless...
We were a way past ["Rule Of Three"](https://en.wikipedia.org/wiki/Rule_of_three_(computer_programming)) and the refactoring was a due in my opinion. Currently, there are 5 sends.
> The PR is net +107 lines of code. but does # of lines code really matter in such cases? # of lines of code would increases if a piece...
> What would be the goal of splitting out the runestone types into a separate crate? Just for better segregation, I feel that it's easier to segregate them now than...
> > @lugondev you can actually, in batch.yaml you'll have to mention the `parent` > > > > am I misunderstanding, or isn't this the same as the first answer...
Wait, does it show remaining supply?