twopointzero
Implement this Pull Request in AioiLight/TJAPlayer3 (2P Support)
There's this pull request in AioiLight/TJAPlayer3: 2Pへの本格対応 (translation: Proper Implementation of 2P)
Since AioiLight is no longer updating TJAPlayer3, will you merge this pull request to your TJAPlayer3? If you need help with understanding what AioiLight and Seseragi255 said there, I can translate it for you.
Hi @KabanFriends! I too would like to merge some of those PRs but have a couple of challenges worth mentioning:
One challenge is that this fork is based on upstream's 1.6.x branch but those PRs target master. 1.6.x was quite far ahead of master at that time, and included some major source code reorganization by AioiLight. It can make PRs against upstream master hard to update for post-1.6.x.
The other main challenge is that I don't have time for that size of PR update to merge into a post-1.6.x target.
Are you able to open a new PR with those changes, but targeting this fork's develop branch?
If not then perhaps we can slowly work on bringing this one over. It just might take a while given my current personal and professional schedule.
As for translation, thanks for the offer! I generally get by on machine translation and that usually works quite well, but if something isn't clear enough and I need some human translation I'll let you know.
I'll hold this issue open for now as a reminder to look into this and other upstream PRs a bit later.
