TJAPlayer3 icon indicating copy to clipboard operation
TJAPlayer3 copied to clipboard

Use the sixth Balloon_Breaking texture to show the balloon pop

Open twopointzero opened this issue 5 years ago • 2 comments

Can you write a one-sentence description of your request? Six Balloon_Breaking textures are loaded in TextureLoader but only five are ever selected and rendered.

What is the current behavior? I have not double-checked the behaviour since spotting this in the code, but I suspect the balloon never appears to pop and rather just disappears.

What is the expected behavior? The balloon should pop instead of disappear. Check other forks as they may have addressed this.

What is the motivation / use case for changing the behavior? Not popping would be odd.

twopointzero avatar May 31 '20 04:05 twopointzero

This could be skin related. If the skin is supposed to have 5 sprites and added 1 later on; without delving in the SkinConfig.ini, the added sprite is not acknowledged.

Game_Chara_Motion_Normal=13,13,12,11,10,9,8,7,6,5,4,3,2,1,0,0,13,13,12,11,10,9,8,7,6,5,4,3,2,1,0,0 is included in the config file, I think this has effect on display order of sprites.

gczark avatar Aug 22 '20 13:08 gczark

It's actually simpler than that, somewhat thankfully :). The code literally loads a hard coded set of six textures and then iterates over that set with a hard coded assumption that there are only five.

twopointzero avatar Aug 22 '20 13:08 twopointzero