pandas-ta icon indicating copy to clipboard operation
pandas-ta copied to clipboard

Published 20 hours ago • verified publisher icon twopirllc

Add GHA workflow for testing

Open kfy-incom opened this issue 2 years ago • 4 comments

This PR adds a Github Actions workflow for testing the pandas-ta package, by running its test suite.

Currently, there are tests that are failing in the main branch. These are not visible in this PR, as the workflow is not being run (I assume because I am not a maintainer of this repo). To see the output, go to my fork of the project: https://github.com/Karsten-Fyhn/pandas-ta/pull/1/checks

kfy-incom avatar Sep 01 '22 10:09 kfy-incom

@Karsten-Fyhn,

Is this one better than PR #581 ?

KJ

twopirllc avatar Sep 09 '22 22:09 twopirllc

It's the same one - but now actually ready for review :)

kfy-incom avatar Sep 12 '22 06:09 kfy-incom

Hi @Karsten-Fyhn,

Looks good mostly. 😎

It seems to be testing the main branch which is good. But can it also test the development branch?

Thanks, KJ

twopirllc avatar Sep 20 '22 22:09 twopirllc

Hi @Karsten-Fyhn,

Looks good mostly. sunglasses

It seems to be testing the main branch which is good. But can it also test the development branch?

Thanks, KJ

Hi @twopirllc , Sure - just added it. Best, Karsten

kfy-incom avatar Sep 21 '22 05:09 kfy-incom

Hmmm... still installing pandas-ta-0.3.14b0 and a test failing.

KJ

twopirllc avatar Sep 21 '22 19:09 twopirllc

Hmmm... still installing pandas-ta-0.3.14b0 and a test failing.

KJ

Aah - I understand what you mean now. I have set it up for running on pull requests TO the development branch now. But since this is a PR to master, then it does not run against that branch. If you would like to see it run against the development branch, we would have to open a new PR with my branch against the development branch.

Maybe it is because I am not familiar with your development flow, so I am not constructing this optimally - how do you normally move from idea, to development, to master?

kfy-incom avatar Sep 22 '22 06:09 kfy-incom

@Karsten-Fyhn,

No worries.

how do you normally move from idea, to development, to master?

Starting with v0.3.14b, I decided to do all the major work via the development branch and periodically update the main branch. At the current pace, it's going to be awhile before I can update the main branch since I have at least 6 more TA Lib indicators to port and various other bugs to resolve.

I either make a new branch off development or just edit development and run tests on that branch before updating Github's development branch. So having the GHA testing the development branch also would be reassuring. 😄

Maybe this GH Action from branch other than main may help. 🤷🏼‍♂️

I appreciate you taking the time to help. 😎

Thanks KJ

twopirllc avatar Sep 22 '22 18:09 twopirllc