Tobias Wollgam
Tobias Wollgam
@nieknooijens ok I understand. Then I think you should use 10ms which will respond more smooth.
BTW I can do a code review if you want.
> > All in all it's good, but some minor changes are needed. > > And there is one question belonging layout things. > > Great, I updated the formatting...
> Do these links work? > > [#983 (comment)](https://github.com/performous/performous/pull/983#discussion_r1573269556) [#983 (comment)](https://github.com/performous/performous/pull/983#discussion_r1573274340) It's strange. In the popups of the links I see the start of your comment but a click doesn't...
> #1 regarding the function name I figured it would fit since this is only used when loading the songs initially from db, put and store sound more generic. >...
> > But maybe I miss a thing. If you (@BWagener) are able to relate to call it simple `addHiscore`. > > Yeah I think it'd clash with the existing...
@Baklap4 would be nice if you can test this one , review and merge it. There is no productive code involved. Cause it is very helpful while developing, I hope...
@BWagener there are type issues (look at the mac build). I think somewhere the song id is an `int` but should be `SongId`.
IIRC I started with a value for missing/undefined ids but it was refactored away with a std::optional. Even if that was not my own idea I would suggest this solution....
I looked at the provided data but did not found which song data causes the problem. @BWagener can you get the information which song causes the problem.