prop-types needs to be a direct dependency, not dev

Open stroborobo opened this issue 5 years ago • 2 comments

With React 17 their own depencency on prop-types was removed, however it is needed for this package. In #91 this was fixed once, but broke again with 2ee646e42. Now without this being resolved by a direct dep in a peer dep this issue is back.

Mar 02 '21 13:03 stroborobo

why is this still an issue? This package is unusable in react 17+ if you are not using proptypes in your project.

Jun 23 '21 15:06 vndre

Same issue here. Are we supposed to manually install the prop-types package? Seems much simpler to just have it listed as an internal dependency of react-lazyload.

Sep 03 '21 18:09 rawcomposition