react-lazyload I think this, it should be || not &&. What do you think?

I think this, it should be || not &&. What do you think?

Open little-buddy opened this issue 5 years ago • 3 comments

trafficstars

https://github.com/twobin/react-lazyload/blob/573448e581c50d7996bc61195682de0b7a80f5f4/src/utils/scrollParent.js#L30

Mar 26 '20 10:03 little-buddy

Don't people think the same as me?

Mar 27 '20 04:03 little-buddy

@little-buddy can you please elaborate more on why you think so?

Mar 29 '20 07:03 ameerthehacker

@ameerthehacker I think in some scenarios, as long as the scroll meets one of the vertical or horizontal conditions,

it can be called the container of lazaload, ex, only vertical or only horizontal.

if my scrollParent only vertical，what can I do？

Mar 30 '20 03:03 little-buddy