react-lazyload icon indicating copy to clipboard operation
react-lazyload copied to clipboard

scrollContainer can't be set to a DOM node

Open jamesrx opened this issue 6 years ago • 4 comments

The documentation specifies that scrollContainer can be set to either a queryselector string, or a DOM node, and the propTypes reflect this as well.

Currently, if anything other than a string is passed as the value of scrollContainer, the value is ignored.

An object should be accepted instead of only a string.

jamesrx avatar Oct 11 '19 18:10 jamesrx

Addressed by #276 - Not yet merged

Nantris avatar Dec 04 '19 21:12 Nantris

@twobin what about merge?

eseQ avatar Feb 10 '20 11:02 eseQ

For what it's worth, the solution mostly worked, but it wasn't enough. Things still weren't loading as expected reliably enough for production and we scrapped it.

Nantris avatar Feb 10 '20 20:02 Nantris

I can confirm that the scrollContainer mechanism only manage the query selector and not the DOM node as specified in docs. Using the query selector works for me.

TheSimon9 avatar Dec 07 '20 14:12 TheSimon9