react-lazyload icon indicating copy to clipboard operation
react-lazyload copied to clipboard

fix(lazyload): create separate file to avoid circular deps inside

Open pulpiks opened this issue 7 years ago • 5 comments

pulpiks avatar Sep 19 '18 15:09 pulpiks

Coverage Status

Coverage remained the same at 75.904% when pulling c582faa2724cc8a394631ba11d27e1cdd4566941 on pulpiks:fix/removeCircularDependencies into b78c9047d66590c56e6b2de517a9dbc8b13f4126 on jasonslyvia:master.

coveralls avatar Sep 19 '18 15:09 coveralls

please remove those generated .min.js files so we can have a better diff

jasonslyvia avatar Sep 20 '18 02:09 jasonslyvia

in other words just leave those changes in src/

jasonslyvia avatar Sep 20 '18 02:09 jasonslyvia

@jasonslyvia done.

pulpiks avatar Oct 02 '18 12:10 pulpiks

@pulpiks I think this is a duplicate PR for #213

ameerthehacker avatar Jan 28 '19 11:01 ameerthehacker