CardinalPGM icon indicating copy to clipboard operation
CardinalPGM copied to clipboard

Localize death messages

Open Pablete1234 opened this issue 9 years ago • 6 comments

[NOTE] I'll finnish this when #892 is merged, because #892 may have to change how all of this works

fixes #833 Has some bugs atm, needs testing

Bugs: /kill shows DEATH_VOID instead of DEATH_SUICIDE

Death causes that show default message (i think this is because killer is not null, it's a entity that's not a player):

/summon PrimedTnt (or dispenser) (DEATH_EXPLOSION) Falling anvil (DEATH_FALLING_BLOCK) /summon Potion (or dispenser) (DEATH_POTION) /summon Arrow (or dispenser) (DEATH_PROJECTILE) /summon Arrow (or dispenser) knocks a player

Death causes i can't test:

LightningBolt (DEATH_LIGHTNING) (/summon LightingBolt doesn't work (sportbukkit?)) Starvation (DEATH_STARVATION) (having 0 hunger doesn't remove health)

Pablete1234 avatar Aug 23 '15 01:08 Pablete1234

Cool :smile: Looking forward to merging this

twizmwazin avatar Aug 23 '15 01:08 twizmwazin

GG @Pablete1234 you are a boss hahaa

ghost avatar Aug 23 '15 12:08 ghost

Item names should be translated with translate components https://www.spigotmc.org/wiki/the-chat-component-api/#client-side-translations

connorjayr avatar Aug 23 '15 15:08 connorjayr

@iEli2tyree011 do you know any way of getting "tile.stone.stone.name" from the block? thx elly: CraftItemStack.asNMSCopy(itemStack).a()

Pablete1234 avatar Aug 26 '15 10:08 Pablete1234

@twizmwazin add the WIP tag, this is going to take a while

Pablete1234 avatar Aug 27 '15 12:08 Pablete1234

I would like to call testers, this should have the main funcionallity implemented, but i'm sure this will have bugs, so plase test this and tell me your results

Pablete1234 avatar Sep 09 '15 02:09 Pablete1234