CardinalPGM icon indicating copy to clipboard operation
CardinalPGM copied to clipboard

Plugin fails to load when there is an error in ranks.xml

Open ghost opened this issue 9 years ago • 10 comments

http://pastebin.com/9r8vskDg

ghost avatar Aug 07 '15 22:08 ghost

Please give us the full stack trace

ElliottWhyman avatar Aug 07 '15 22:08 ElliottWhyman

Please also give us your ranks.xml file, found in plugins/Cardinal

connorjayr avatar Aug 07 '15 22:08 connorjayr

@iEli2tyree011 can an error in the rank.xml cause the plugin to not load?

ghost avatar Aug 07 '15 22:08 ghost

apparently it can

ghost avatar Aug 07 '15 22:08 ghost

Let's keep this open, we can have the plugin use default ranks if the config file is invalid

twizmwazin avatar Aug 08 '15 02:08 twizmwazin

@twizmwazin if there's an invalid ranks file it should use default, but keep the other one so it can be fixed, and tell the error in console (and maybe warn op's when they join)

Pablete1234 avatar Aug 08 '15 02:08 Pablete1234

@Pablete1234 That is what I planned on having, although rather than having a chat message just spam the console on startup

twizmwazin avatar Aug 08 '15 03:08 twizmwazin

@twizmwazin if you have a hosted server, you often don't look at the console, and someone kinda non-experienced trying to setup a rank system may be like "why is it not working!?!?!?" but a chat message sent to op's when the join "This server has an unvalid ranks.xml file" would be enough, and maybe also for the rotation file

Pablete1234 avatar Aug 08 '15 03:08 Pablete1234

I'd rather just use the console. If someone is having an issue, it is expected they check the console for any errors.

twizmwazin avatar Aug 08 '15 03:08 twizmwazin

When theres an error on my version, theres no crashes, just loads the default ranks

angelortizau avatar Aug 23 '15 01:08 angelortizau