CardinalPGM icon indicating copy to clipboard operation
CardinalPGM copied to clipboard

Add chance attribute to blockdrops.

Open Pugzy opened this issue 8 years ago • 3 comments

I found most of these issues whilst testing #1039 so I thought I'd fix them too.

This class could do with a re-write to enable the punch and trample elements in the future.

  • Add chances to item drops.
  • Gather wrongtool info when attribute and element.
  • Fix usage of wrongtool.
  • Fix giving incorrect experience.

Update 1:

  • Use new parsing.
  • Gather reset of elements.

Update 2:

  • Can't remember how on earth this stuff works.
  • Create new method for generateDrops() to be used in all events.
  • Start support for trample and punch.

Pugzy avatar Jun 16 '16 17:06 Pugzy

Looks good, I'm fine with this being merged. I don't know if @Pablete1234 has other opinions.

twizmwazin avatar Jun 30 '16 05:06 twizmwazin

@twizmwazin It's not ready yet, trample and punch don't work, @iPGz was waiting for cause filters to be implemented first

Pablete1234 avatar Jun 30 '16 05:06 Pablete1234

I still see some debug messages and tests arround, so i'm labeling as WIP

Pablete1234 avatar Nov 22 '16 05:11 Pablete1234