CardinalPGM icon indicating copy to clipboard operation
CardinalPGM copied to clipboard

Change Whitelist status messages, fixes #986

Open Pablete1234 opened this issue 8 years ago • 8 comments

image

(the last number at the end of each line, is the same)

What else should it say? or what should it say instead?

Pablete1234 avatar May 01 '16 15:05 Pablete1234

The enum should be more descriptive

twizmwazin avatar May 01 '16 21:05 twizmwazin

@twizmwazin I know, it's like that until we decide the final message

Pablete1234 avatar May 01 '16 21:05 Pablete1234

maybe remove the online player count completly? that way only the 2nd sentence would be there

Pablete1234 avatar May 01 '16 22:05 Pablete1234

Yikes, I got distracted studying for AP, was playing with a fix for this. Sorry for not being able to push it out D: Thanks @Pablete1234 for taking it over.

SungMatt avatar May 04 '16 06:05 SungMatt

@SungMatt you can still push your changes or ssy what you think the message should be, this isn't done yet, it's just here to "open the debate" on what the message should be

Pablete1234 avatar May 04 '16 08:05 Pablete1234

how about: There are a total of {0} whitelisted players, out of the {1} online players, {2} are whitelisted ?

Pablete1234 avatar Jun 06 '16 12:06 Pablete1234

There are a total of {0} whitelisted players. Out of the {1} online players, {2} are whitelisted.

Additionally, have a few cases to change the verbs when there is only one online player, or one whitelisted.

twizmwazin avatar Jun 06 '16 13:06 twizmwazin

@twizmwazin yeah, i know it should change player/s is/are etc

Pablete1234 avatar Jun 06 '16 13:06 Pablete1234