Ishan Bhanuka

I think there are a couple of parts here. Adding an interface for the config object is definitely a good to have. It'll make deployments hard to get wrong and...

Hmm yeah when you put it this way distributing as an npm package does have advantages. So if were to publish one. Then this repo would actually have two projects...

Thanks for sharing these options both of them work. `useRecords: false` and `mapsAsObjects: true`. I was trying to do something similar by explicitly creating objects like this below. Do these...

One limitation with the multisig implementation is that it does not allow different roles to approve the action. So in this particular example if I want the manager and the...

I believe `simple_multisig` is a common terminology in payments and contracts. It's just that I missed it when reading the documentation. Still the documentation can be updated to reflect in...

In the meantime I'll look into implementing a custom approval flow for this. It's for the best I think since the example will demonstrate a slightly more complex approval implementation.

I've updated the example with a custom approval management. I've also noted down my documentation and design comments as `TODO` in `src/approval/mod.rs`. Overall I feel that the approval manager is...

I'm working on the sandbox tests and I often get errors like this. ``` thread 'successful_request' panicked at 'called `Result::unwrap()` on an `Err` value: ExecutionResult { total_gas_burnt: 5079091640520, transaction: ExecutionOutcome...

Also I found that there are no examples where the output of a transaction call is used. While trying to do this I found that the result of a transaction...

A custom implementation of ApprovalManager is pretty non-trivial to use. After initializing the configuration in the contract `#[init]` function, it still gives not initialized errors when running tests. ```rust impl...