typeahead.js icon indicating copy to clipboard operation
typeahead.js copied to clipboard

Added WAI-ARIA support, issue #397

Open ova2 opened this issue 10 years ago • 13 comments

I've added a good WAI-ARIA support. See the issue #397. Please accept this pull request. Thanks.

ova2 avatar Sep 10 '14 21:09 ova2

Thanks @ova2 this is fantastic! I tested it with JAWS 14 and it works great!

rajeshduggal avatar Oct 30 '14 21:10 rajeshduggal

Glad to hear that is works with JAWS! I tested with ChromeVox and NVDA. It works really good. We use this in a big internet application.

ova2 avatar Oct 30 '14 21:10 ova2

I tested this with the following combinations:

Screen Readers

  • Jaws
  • NVDA

Browsers

  • IE9
  • FireFox 26
  • Chrome 39

All combinations worked correctly, except for Chrome/NVDA and Chrome/JAWS.

In the case of Chrome when the suggestions first appeared, they were not read out. When I added an additional character, they were read out correctly. Chrome seems to need the content of the "tt-status" span updated to a non empty value, then updated a second time. That triggers the DOM change event in Chrome that JAWS/NVDA use.

I'll see what changes I need to make to get this scenario to work.

dfrencham avatar Feb 05 '15 05:02 dfrencham

Could this be merged? The one test failure is a quick hit.

StevenACoffman avatar Apr 14 '15 21:04 StevenACoffman

Hello I need to suggest an accessible typeahead, my colleague Raj (above) suggested this one, may I ask what the "one test failure" was @StevenACoffman?

mejsullivan avatar Apr 17 '15 20:04 mejsullivan

It's trivial. Click the Travis CI build failed details and you see:

(Linux) Typeahead #destroy should revert DOM changes FAILED
    Expected '<input type="text" aria-owns="tt-aed4add3-d4d0-dea4-da72-e344b985cc2a" aria-expanded="false" class="tt-input" autocomplete="off" spellcheck="false" role="combobox" aria-autocomplete="both" style="position: relative; vertical-align: top; background-color: transparent; " dir="auto">' not to have class 'tt-input'.
PhantomJS 1.9 (Linux): Executed 230 of 230 (1 FAILED)
JS 1.9 (Linux): Executed 230 of 230 (1 FAILED) (1.013 secs / 0.846 secs)

StevenACoffman avatar Apr 17 '15 20:04 StevenACoffman

Please can this be reopened?

JoeChapman avatar Nov 12 '15 16:11 JoeChapman

I'd love to see this work make it to a release!

kaelig avatar May 23 '16 22:05 kaelig

The build is failing on one of the unit tests. Should the unit test be updated in the PR as well?

stevenao avatar Jun 04 '16 00:06 stevenao

Any update on this? Would love to have this ability on our website.

nickdenardis avatar Nov 06 '17 18:11 nickdenardis

Any update on this?

atainton avatar Nov 23 '17 09:11 atainton

Note that autocomplete.js (a typeahead.js fork) was made more accessible via https://github.com/algolia/autocomplete.js/pull/148, in case someone wants to use that instead.

kaelig avatar Nov 24 '17 20:11 kaelig

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 18 '19 15:07 CLAassistant