typeahead.js icon indicating copy to clipboard operation
typeahead.js copied to clipboard

Fix limit bug when async update occurs

Open mirkobeine opened this issue 10 years ago • 9 comments

When having 0 rendered suggestions, a limit of 5 and a suggestions array with length of 5, nothing will be rendered. This is due to the fact that the "rendered" variable is updated before the suggestions are sliced. With the given PR, everything works as expected.

mirkobeine avatar Dec 21 '15 16:12 mirkobeine

We experienced this bug too. Why is this not merged yet?

MrCsabaToth avatar Jan 28 '16 17:01 MrCsabaToth

+1 same error here.

On limit 5 the suggestions.length of 3, 4 and 5 will not work properly. Length 1 and 2 seem to work accidentally

Workaround could be increasing the limit.

parrin avatar Mar 01 '16 16:03 parrin

+1

Same issues as #1499 #1497 #1485

I hope this gets fixed soon

MerickOWA avatar Mar 30 '16 17:03 MerickOWA

+1

The commit is identical to the solution I implemented before finding this PR.

timothyblam avatar Jun 16 '16 20:06 timothyblam

+1

Carscafmoo avatar Jun 29 '16 23:06 Carscafmoo

+1 solves the problem I observed

ypnos-web avatar Jul 05 '16 16:07 ypnos-web

+1

kmussel avatar Jul 29 '16 14:07 kmussel

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Mirko Beine seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 18 '19 15:07 CLAassistant

"Mirko Beine seems not to be a GitHub user." vs. https://github.com/mirkobeine ? The CLA bot went kookoo?

MrCsabaToth avatar Jul 18 '19 16:07 MrCsabaToth