Fix limit bug when async update occurs
When having 0 rendered suggestions, a limit of 5 and a suggestions array with length of 5, nothing will be rendered. This is due to the fact that the "rendered" variable is updated before the suggestions are sliced. With the given PR, everything works as expected.
We experienced this bug too. Why is this not merged yet?
+1 same error here.
On limit 5 the suggestions.length of 3, 4 and 5 will not work properly. Length 1 and 2 seem to work accidentally
Workaround could be increasing the limit.
+1
Same issues as #1499 #1497 #1485
I hope this gets fixed soon
+1
The commit is identical to the solution I implemented before finding this PR.
+1
+1 solves the problem I observed
+1
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
Mirko Beine seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.
"Mirko Beine seems not to be a GitHub user." vs. https://github.com/mirkobeine ? The CLA bot went kookoo?