typeahead.js icon indicating copy to clipboard operation
typeahead.js copied to clipboard
verified publisher icon twitter

Bugfix in counting rendered async results

Open teajaymars opened this issue 10 years ago • 5 comments

Preconditions for the bug:

  • There are no sync results
  • You set a limit, eg. 5
  • The async interface returns that number of results -- ie. precisely 5

No results will be rendered. I've looked at the logic and it doesn't make sense. This pull request is what I think you're actually trying to achieve.

teajaymars avatar Jun 14 '15 22:06 teajaymars

:+1:

danielspector avatar Jun 19 '15 02:06 danielspector

Is typeahead alive? Do you need help merging this?

vvo avatar Jun 19 '15 12:06 vvo

I just implemented it on the front page of http://data.london.gov.uk/, so I really hope so.

teajaymars avatar Jun 19 '15 13:06 teajaymars

Looks like a duplicate of #1212, has been fixed over at corejavascript/typeahead.js#8

jlbooker avatar Oct 05 '15 01:10 jlbooker

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 29 '19 17:07 CLAassistant