typeahead.js icon indicating copy to clipboard operation
typeahead.js copied to clipboard

Render all async results when there were no sync results

Open coopy opened this issue 9 years ago • 45 comments

Update rendered-count after async results have displayed. This ensures that all async results are rendered.

coopy avatar May 05 '15 00:05 coopy

+1. This closes the issue #1232

rafaelGuerreiro avatar May 13 '15 13:05 rafaelGuerreiro

This. Should be merged because #1200 doesn't work, at least for me. Spent hours of work trying to figure out what was wrong.

gremo avatar Jun 16 '15 09:06 gremo

+1 this patch worked for me

alexfarrill avatar Jun 16 '15 16:06 alexfarrill

+1 please merge!

theoephraim avatar Jun 23 '15 20:06 theoephraim

+1

StupidCodeFactory avatar Jun 26 '15 09:06 StupidCodeFactory

+1

siawyoung avatar Jun 30 '15 15:06 siawyoung

+1 very nasty bug, should be released ASAP.

For me, both PRs work, maybe because my update is called only once..

razvanphp avatar Jul 01 '15 23:07 razvanphp

+1 Please merge ASAP!!

Glavin001 avatar Jul 07 '15 17:07 Glavin001

Please merge

omri avatar Jul 12 '15 20:07 omri

I am simply using @per-nilsson 's Fork as my project's dependency, until this is merged and resolved. Without it, I cannot use Tyepahead.js at all.

Glavin001 avatar Jul 13 '15 01:07 Glavin001

Please merge asap +1

aj7 avatar Jul 14 '15 11:07 aj7

Why isn't this merged yet? O_o

thomassnielsen avatar Jul 14 '15 17:07 thomassnielsen

You sir are my new favourite person of the month I've been scratching my head for 1 month wondering what I was doing wrong (without having time to step through the code)

anarkia1985 avatar Jul 15 '15 15:07 anarkia1985

:+1: merge please :)

SebCorbin avatar Jul 16 '15 09:07 SebCorbin

This merge contains fixes for some devastating bugs, why hasn't this been merged and released yet?

krazyjakee avatar Jul 17 '15 15:07 krazyjakee

:+1: Just migrated from 0.10.5 and this bug had me very confused. Please merge.

Everlag avatar Jul 18 '15 20:07 Everlag

Yes, It's sad they don't maintain this properly. I can't imagine all the time lost for people diagnosing the same bug over and over again :confused:

jarthod avatar Jul 18 '15 20:07 jarthod

@jharding: Would it be possible for a GitHub team be made to provide access to typeahead.js for open-source contributors to help maintain this project?

I know I would be very eager to help out, as I am sure many others would, too. It would not be ideal for users to have to keep making forks and solving issues on their own than many others have experiences and likely solved already. How can we help remedy this? Thank you.

Glavin001 avatar Jul 18 '15 21:07 Glavin001

Agree this should be merged, the current release is broken without it. Please appoint some new maintainers twitter!

In the meantime, I'm using @per-nilsson's distribution builds in his fork: https://github.com/per-nilsson/typeahead.js/tree/fix-async-render-dist/dist

lordelph avatar Jul 20 '15 06:07 lordelph

+1 please!!!

bwanicur avatar Jul 21 '15 23:07 bwanicur

+1 please! tweeted you. please announce more maintainer

fsmeier avatar Jul 22 '15 08:07 fsmeier

+1 Release please!

akiko-pusu avatar Jul 23 '15 01:07 akiko-pusu

+1

halissonvit avatar Aug 11 '15 22:08 halissonvit

+1 Merge please!

denis111 avatar Aug 12 '15 13:08 denis111

seems repo isn't supported anymore? this bug still alive... merge it man!

terrasoff avatar Aug 31 '15 17:08 terrasoff

For anyone who is using my fork to take advantage of this fix (@Glavin001, @lordelph et al): I've changed my github username. The repo with the fixed branch is now available at https://github.com/coopy/typeahead.js/tree/fix-async-render-dist

You can reference it in your package.json like this (using npm v2.11.3):

{
  "dependencies: {
    "typeahead.js": "coopy/typeahead.js#fix-async-render-dist"
  }
}

coopy avatar Sep 01 '15 03:09 coopy

+1 and thank you very much @coopy

Kikketer avatar Sep 17 '15 14:09 Kikketer

+1 Merge please!

ynh-zz avatar Sep 17 '15 14:09 ynh-zz

+1 Merge please!

Victori0us avatar Sep 24 '15 11:09 Victori0us

the project seems abandoned, no maitainer around since April, so not likely :)

gaborbernat avatar Sep 24 '15 12:09 gaborbernat