typeahead.js
typeahead.js copied to clipboard
Render all async results when there were no sync results
Update rendered-count after async results have displayed. This ensures that all async results are rendered.
+1. This closes the issue #1232
This. Should be merged because #1200 doesn't work, at least for me. Spent hours of work trying to figure out what was wrong.
+1 this patch worked for me
+1 please merge!
+1
+1
+1 very nasty bug, should be released ASAP.
For me, both PRs work, maybe because my update is called only once..
+1 Please merge ASAP!!
Please merge
I am simply using @per-nilsson 's Fork as my project's dependency, until this is merged and resolved. Without it, I cannot use Tyepahead.js at all.
Please merge asap +1
Why isn't this merged yet? O_o
You sir are my new favourite person of the month I've been scratching my head for 1 month wondering what I was doing wrong (without having time to step through the code)
:+1: merge please :)
This merge contains fixes for some devastating bugs, why hasn't this been merged and released yet?
:+1: Just migrated from 0.10.5 and this bug had me very confused. Please merge.
Yes, It's sad they don't maintain this properly. I can't imagine all the time lost for people diagnosing the same bug over and over again :confused:
@jharding: Would it be possible for a GitHub team be made to provide access to typeahead.js for open-source contributors to help maintain this project?
I know I would be very eager to help out, as I am sure many others would, too. It would not be ideal for users to have to keep making forks and solving issues on their own than many others have experiences and likely solved already. How can we help remedy this? Thank you.
Agree this should be merged, the current release is broken without it. Please appoint some new maintainers twitter!
In the meantime, I'm using @per-nilsson's distribution builds in his fork: https://github.com/per-nilsson/typeahead.js/tree/fix-async-render-dist/dist
+1 please!!!
+1 please! tweeted you. please announce more maintainer
+1 Release please!
+1
+1 Merge please!
seems repo isn't supported anymore? this bug still alive... merge it man!
For anyone who is using my fork to take advantage of this fix (@Glavin001, @lordelph et al): I've changed my github username. The repo with the fixed branch is now available at https://github.com/coopy/typeahead.js/tree/fix-async-render-dist
You can reference it in your package.json
like this (using npm v2.11.3
):
{
"dependencies: {
"typeahead.js": "coopy/typeahead.js#fix-async-render-dist"
}
}
+1 and thank you very much @coopy
+1 Merge please!
+1 Merge please!
the project seems abandoned, no maitainer around since April, so not likely :)