twitter-text icon indicating copy to clipboard operation
twitter-text copied to clipboard

Add useful isValidHashtag() for java

Open johnlinp opened this issue 5 years ago • 10 comments

Problem

The functions like isValidHashtag() in js and valid_hashtag() in ruby are useful, but there is no such function for java.

Solution

Add isValidHashtag() in Validator.java and add test cases in ValidatorTest.java.

Result

Java people can easily check if a text is a valid hashtag via isValidHashtag().

johnlinp avatar Jan 08 '19 04:01 johnlinp

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jan 08 '19 04:01 CLAassistant

Passing to @leeaustinadams for review - thanks for the PR!

andypiper avatar Jan 08 '19 12:01 andypiper

Hi @leeaustinadams Any updates on this PR? Thanks!

johnlinp avatar Jan 28 '19 05:01 johnlinp

Slowly orbiting back around to looking at twitter-text, will get you an update shortly.

leeaustinadams avatar Feb 14 '19 21:02 leeaustinadams

Hi @leeaustinadams I removed the redundant import line. Please take a look. Thank you.

johnlinp avatar Feb 16 '19 03:02 johnlinp

Thanks! For this repo we need to merge it internally first and then push it back to github. Once that has happened I will close this pull request but you will be attributed in the commit message.

leeaustinadams avatar Feb 16 '19 04:02 leeaustinadams

Hi @leeaustinadams Is there any updates on this PR?

johnlinp avatar Apr 08 '19 09:04 johnlinp

I'm trying to find a time to distribute this internally as well since we need to do that in order to accept your change and push it back to GitHub. Thank you for your patience.

leeaustinadams avatar Apr 24 '19 19:04 leeaustinadams

Hi @leeaustinadams and @andypiper,

I've signed the CLA, but the above check still shows "license/cla Pending — Contributor License Agreement is not signed yet." Do you have any idea why? Thanks.

johnlinp avatar Aug 05 '20 02:08 johnlinp

I assume this repository is no longer maintained - I'm unable to help here.

andypiper avatar Dec 07 '23 13:12 andypiper