twitter-text icon indicating copy to clipboard operation
twitter-text copied to clipboard

Issue #254: support exclamation point as ending char in path

Open tparsioan opened this issue 7 years ago • 3 comments

This addresses the issue in 'extractUrlsWithIndices' function where it does not properly recognize the full URL if the ending character in the path is an exclamation point (!). With a URL as such: https://www.domain.com/locale/#!?key1=value1&key2=value2

The complete URL 'https://www.domain.com/locale/#!?key1=value1&key2=value2' will be recognized as a URL instead of just the part preceding the exclamation point 'https://www.domain.com/locale/#'.

tparsioan avatar Feb 22 '18 22:02 tparsioan

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: tparsioan
:x: taufik-parsioan
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Feb 22 '18 22:02 CLAassistant

@rcastera

tparsioan avatar May 11 '18 20:05 tparsioan

@kaushlakers can you take a look?

rcastera avatar May 14 '18 17:05 rcastera