twitter-text icon indicating copy to clipboard operation
twitter-text copied to clipboard

Published 20 hours ago • verified publisher icon twitter

2.0 has a test for "Invalid Tweet: 141 characters"

Open dequis opened this issue 7 years ago • 2 comments

https://github.com/twitter/twitter-text/blob/34dc1dd9f10e9171100cdff0cb2b7a9ed9ea2bd6/conformance/validate.yml#L28-L30

Is that an oversight? Or do tests pass with this?

dequis avatar Dec 16 '17 17:12 dequis

Hi @dequis. Tests still pass because we still support the old way of counting and they're configured to run that way. It's based on the config defined here https://github.com/twitter/twitter-text/tree/master/config

We will probably get rid of them soon. Thoughts @sudhee @dlamacchia @leeaustinadams ? On when we want to do this.

kaushlakers avatar Dec 17 '17 18:12 kaushlakers

Yeah, this could stand to be cleaned up. As long as we support v1, we might just move these tests to a v1 section and clarify why they're still there.

dlamacchia avatar Jan 12 '18 06:01 dlamacchia