twemproxy icon indicating copy to clipboard operation
twemproxy copied to clipboard

Fix using mbuf after returning it to mbuf free list for redis mset.

Open huachaohuang opened this issue 8 years ago • 3 comments

huachaohuang avatar Mar 22 '16 02:03 huachaohuang

I merge the bugfix in #486 , but using mbuf_length on a mbuf is not a good way after putting the mbuf to the free list. So can you create a new pr based on the master, I want to merge your code.

andyqzb avatar Aug 26 '16 13:08 andyqzb

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jul 29 '19 17:07 CLAassistant

I merge the bugfix in 486 , but using mbuf_length on a mbuf is not a good way after putting the mbuf to the free list. So can you create a new pr based on the master, I want to merge your code.

My understanding of this: twemproxy is single threaded so it doesn't cause issues in practice, but would agree in principle (e.g. if mbuf_free were to be replaced with an actuall free call as a debug compile option to debug memory leaks or use-after free)

TysonAndre avatar Jun 16 '21 20:06 TysonAndre