thrift_client icon indicating copy to clipboard operation
thrift_client copied to clipboard

Thrift IDL contains the method handled_proxy() causes an error

Open tanin47 opened this issue 12 years ago • 1 comments

Hello All,

I wonder if we have a plan to handle this case: AbstractThriftClient reads the Thrift IDL and generate the methods dynamically.

When an IDL's method conflicts with the existing method, it produces an error.

One solution is to rename every method in AbstractThriftClient to have a weirder name, e.g. __handled_proxy().

What do you guys think? -Tanin

tanin47 avatar Apr 15 '13 21:04 tanin47

I agree that this could be an issue. So far, however, no one's run into it. We have a few libraries that wrap and override handled_proxy in order to inject stats reporting so I'm hesitant to make the change in the name of future proofing.

sprsquish avatar Apr 16 '13 15:04 sprsquish