the-algorithm icon indicating copy to clipboard operation
the-algorithm copied to clipboard

optimized the algorithm

Open Cosmelon opened this issue 1 year ago • 32 comments

took care of some backend optimizations to increase algorithm workflow

Cosmelon avatar Apr 01 '23 15:04 Cosmelon

Bro lmao

SCHW18TZ avatar Apr 01 '23 15:04 SCHW18TZ

Thanks for the contribution! But i think your code lacks tests

Killjoyer avatar Apr 01 '23 15:04 Killjoyer

LGTM 🔥

Y2KForever avatar Apr 01 '23 15:04 Y2KForever

LGTM

aldy97 avatar Apr 01 '23 15:04 aldy97

It seems to work for me

ryanmattos avatar Apr 01 '23 15:04 ryanmattos

image

dzikrisyairozi avatar Apr 01 '23 15:04 dzikrisyairozi

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Apr 01 '23 15:04 CLAassistant

Thanks for the contribution! But i think your code lacks tests

Thanks for the feedback, I added further optimizations to make the need for tests unnecessary.

Cosmelon avatar Apr 01 '23 15:04 Cosmelon

image

nobodyindustries avatar Apr 01 '23 16:04 nobodyindustries

LGTM

poleshe avatar Apr 01 '23 16:04 poleshe

What a bunch of kids

kadeksuryam avatar Apr 01 '23 16:04 kadeksuryam

You know, I'm still looking through some of the code I've re-written, and come to think of it I actually have further progress to make, will be updating as I fix.

Cosmelon avatar Apr 01 '23 17:04 Cosmelon

LGTM

ScribbleDribble avatar Apr 01 '23 17:04 ScribbleDribble

bug free code, ship it!! 🚀🚀

rdnsyh avatar Apr 01 '23 17:04 rdnsyh

LGTM

leonidlist avatar Apr 01 '23 17:04 leonidlist

lgtm

SaltfishAmi avatar Apr 01 '23 19:04 SaltfishAmi

LGTM

nrmu9 avatar Apr 01 '23 20:04 nrmu9

LGTM

ANormalProgrammer avatar Apr 02 '23 03:04 ANormalProgrammer

LGTM

parnexcodes avatar Apr 02 '23 06:04 parnexcodes

LGTM

kyeboard avatar Apr 03 '23 08:04 kyeboard

LGTM

wolfvandenbussche avatar Apr 03 '23 13:04 wolfvandenbussche

LGTM

kdata12 avatar Apr 03 '23 16:04 kdata12

I don't see anything wrong with it. LGTM

splurf avatar Apr 03 '23 19:04 splurf

LGTM

ZeroDiscord avatar Apr 04 '23 08:04 ZeroDiscord

Code stripping is a great optimization technique

pgh268400 avatar Apr 05 '23 11:04 pgh268400

Took some time to review it. But yes LGTM!

helderpgoncalves avatar Apr 05 '23 19:04 helderpgoncalves

LGTM

happytalkSU avatar Apr 06 '23 01:04 happytalkSU

I am sure It would run instantly just like there is nothing to compile after these changes.

gokayumutlu avatar Apr 06 '23 05:04 gokayumutlu

LGBT

wodnjse avatar Apr 08 '23 15:04 wodnjse

LGTM

ghost avatar Apr 12 '23 13:04 ghost