the-algorithm icon indicating copy to clipboard operation
the-algorithm copied to clipboard

The Rare Bug with GeoUtils May have Been Fixed in Lucene `8.5.1`

Open MarcusSorealheis opened this issue 1 year ago • 4 comments

Describe the bug For a tangentially related project, I started to look through the Twitter source code for geospatial search queries and I came across this method that looked slightly familiar:

https://github.com/twitter/the-algorithm/blob/138bb519975407d4ea0dc1478d897d451ef05dab/src/java/com/twitter/search/earlybird/search/GeoQuadTreeQueryBuilder.java#L153-L167

Additional context

While not exactly the same issue in the wild, Lucene users recently observed an issue with tessellation of collinear edges - LUCENE-9251. I don't think that it is a common bug or pervasive, given many users have upgraded or were not tessellating on the same line. I do wonder if this issue was resolved by that big fix.

What version of Lucene are you all running? It seems like it's a fork, sort of, but also maybe 7.x or 8.x? I would be happy to try to propose a fix if that's not what this rare bug is related to.

MarcusSorealheis avatar Apr 13 '23 05:04 MarcusSorealheis

Also, are we sure this only happens on occasion? I believe that would suggest a different problem.

MarcusSorealheis avatar Apr 13 '23 05:04 MarcusSorealheis

Thanks @MarcusSorealheis for sharing your discovery.

I'm not sure if it happens only on occasion, anyway for future reference, if anyone feels like doing further analysis, here is the relevant code: https://github.com/apache/lucene-solr/commit/c313365

aloiscochard avatar Apr 13 '23 11:04 aloiscochard

@aloiscochard why are you pretending to be a twitter employee :skull:

thegu5 avatar Apr 14 '23 16:04 thegu5

I don't think they did that. i think they just clicked the links inside the link I shared. I don't think they are a neutral addition. I'm not confident that this is indeed the issue.

MarcusSorealheis avatar Apr 15 '23 22:04 MarcusSorealheis