the-algorithm icon indicating copy to clipboard operation
the-algorithm copied to clipboard
Published 5 months ago • verified publisher icon twitter

increase efficiency

Open realKarthikNair opened this issue 2 years ago • 2 comments

realKarthikNair avatar Apr 08 '23 11:04 realKarthikNair

Hi @realKarthikNair, could you please explain to us your edits describing what did you change and how is it supposed to increase the code efficiency. Also, did you run any benchmarks? Thanks!

ilovelinux avatar Apr 10 '23 14:04 ilovelinux

Hi @realKarthikNair, could you please explain to us your edits describing what did you change and how is it supposed to increase the code efficiency. Also, did you run any benchmarks? Thanks!

Yes, if you ran it you will see there is a 69000% efficiency benchmark and the latency is decreased 420minutes overall this is a very valuable contribution for the Tesla and starlink organizations respectively. Overall, LGTM though, i would do rust rewrite.

Shahi-Paneer avatar Apr 11 '23 16:04 Shahi-Paneer