the-algorithm-ml icon indicating copy to clipboard operation
the-algorithm-ml copied to clipboard

Some classes are defined more than once in the same file

Open robvdl opened this issue 1 year ago • 1 comments

I think in each case the second definition overwrites the initial definition??? at least that is what I would expect.

projects/home/recap/models/config.py

BatchNormConfig is defined twice DropoutConfig is defined twice MlpConfig is defined twice

projects/home/recap/embedding/config.py

SmallEmbeddingBagConfig is defined twice

projects/home/recap/model/entrypoint.py

We have two imports stomping eachother out:

from tml.projects.home.recap.model import config as model_config_mod
import tml.projects.home.recap.model.config as model_config_mod

robvdl avatar Mar 31 '23 20:03 robvdl

On the topic of imports, I do see a few unused imports, but that would be a patch of it's own.

I don't know if any of the imports are required as an import side-effect, one would hope not.

robvdl avatar Mar 31 '23 20:03 robvdl