storehaus icon indicating copy to clipboard operation
storehaus copied to clipboard

Expose Buf instead of ChannelBuffer in storehaus-redis

Open BenFradet opened this issue 8 years ago • 1 comments

Since Finagle is moving away from exposing netty's ChannelBuffer in their API in favor of twitter util's Buf, I think we should too.

From the recent commits, I think the replacement should be complete by Finagle's next release.

BenFradet avatar Jul 03 '16 15:07 BenFradet

Yeah, I think this is a good call. (PS: lesson to be learned here, it is a good idea to hide all your dependencies on your public API in general. We didn't do that in a few places in scalding, I really regret it).

johnynek avatar Jul 03 '16 18:07 johnynek