scalding
scalding copied to clipboard
Type independent gens for TypedPipe/Execution
Generators of TypedPipe/Execution inspired by @erik-stripe talk http://plastic-idolatry.com/erik/oslo2019.pdf
This is great!
I’ll review in detail this week. Exciting to have this level of test coverage.
Cc @non
You may also decide you want a way to make your "key type" generators a bit denser (to ensure you are likely to generate repeated values, allowing your joins to succeed); currently your joins are fairly likely to be empty.
I don't think that's needed in this PR but it's just something else that might be useful later on.
You may also decide you want a way to make your "key type" generators a bit denser (to ensure you are likely to generate repeated values, allowing your joins to succeed); currently your joins are fairly likely to be empty.
I don't think that's needed in this PR but it's just something else that might be useful later on.
That's would be nice.
Forgot to mention, this PR is more proof of concept to see if we want to invest in this more and migrate all tests on this approach, I'm generally like this but want to see your thoughts.
@dieu Got it, that makes sense. I'll defer to others but (maybe obvious) I'm in favor of moving things to this style.