scalding icon indicating copy to clipboard operation
scalding copied to clipboard

Type independent gens for TypedPipe/Execution

Open dieu opened this issue 5 years ago • 6 comments

Generators of TypedPipe/Execution inspired by @erik-stripe talk http://plastic-idolatry.com/erik/oslo2019.pdf

dieu avatar May 17 '19 22:05 dieu

This is great!

I’ll review in detail this week. Exciting to have this level of test coverage.

Cc @non

johnynek avatar May 18 '19 04:05 johnynek

You may also decide you want a way to make your "key type" generators a bit denser (to ensure you are likely to generate repeated values, allowing your joins to succeed); currently your joins are fairly likely to be empty.

I don't think that's needed in this PR but it's just something else that might be useful later on.

non avatar May 20 '19 01:05 non

You may also decide you want a way to make your "key type" generators a bit denser (to ensure you are likely to generate repeated values, allowing your joins to succeed); currently your joins are fairly likely to be empty.

I don't think that's needed in this PR but it's just something else that might be useful later on.

That's would be nice.

dieu avatar May 20 '19 18:05 dieu

Forgot to mention, this PR is more proof of concept to see if we want to invest in this more and migrate all tests on this approach, I'm generally like this but want to see your thoughts.

dieu avatar May 20 '19 18:05 dieu

@dieu Got it, that makes sense. I'll defer to others but (maybe obvious) I'm in favor of moving things to this style.

non avatar May 20 '19 18:05 non

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 16 '19 00:11 CLAassistant