scalding icon indicating copy to clipboard operation
scalding copied to clipboard

[WIP] PullByteBufferOut as a default ordering

Open ianoc-stripe opened this issue 7 years ago • 2 comments

First extraction.

Right now i don't think we need the macros and can probably drop them again.

Naming/code organization and how this should all get imported open to opinions

We could have the defaults show up in the package object ordered serialization itself?

thoughts ? @johnynek @travisbrown

ianoc-stripe avatar Sep 26 '17 23:09 ianoc-stripe

Ok I think this is looking a bit more cleaned up and may be worth looking at again design wise. I'd be slow to merge this as-is if we think develop should always be ready to released since i think for a release we would want to get everything from the macro out and under provided split up. It would be binary breaking since today a single method can be used to do everything. (Though we could possibly inject a different/new whitebox macro to smooth over most of this... but i'm not sure its worth that vs just moving onto a nicer split up world).

There is also a pre-release question here if the old school macros should be under the same package/import as say our ByteBuffer implementations. This would make it harder to shop around and use the ByteBuffer implementation, but then also use Shapeless.

ianoc avatar Sep 27 '17 16:09 ianoc

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 16 '19 00:11 CLAassistant