scalding
scalding copied to clipboard
Scalding repl if just override the entry point will fail
https://github.com/twitter/scalding/blob/develop/scalding-repl/src/main/scala/com/twitter/scalding/ReplImplicits.scala#L139
Refers to the ScaldingShell object, if a user makes their own shell inheriting from ScaldingShell this will break how the code is built I believe.
(I thinnk @ Twitter it won't be hit since this class amongst others are all overridden for local stuff, so if you override enough its ok again...)
@ianoc Can you clarify: You mean the ReplImplicits
is coupled with ScaldingShell
and cannot handle overriding shell
with a ScaldingShell
subclass?
So if you just sub-class ScaldingShell, say you want to provide a default config or do some arg parsing of your own before handling to the ScaldingShell. You'll currently get a whole bunch of serialization errors when you try run things. The ReplImplicit's refer to the object ScaldingShell and as such basically refer to a different interpreter than you'd be running
OK makes sense